setup paginator.py#54
Closed
nh916 wants to merge 5 commits into
Closed
Conversation
* current_page_number is a property with getters and setters * added `fetch_page_from_api()` method
CVilla17
previously approved these changes
Apr 15, 2023
CVilla17
left a comment
CVilla17
left a comment
There was a problem hiding this comment.
Not really my expertise, but looks right. Should there be some thing to indicate total amount of pages?
Contributor
Author
|
merging this PR into wip_api because it is needed there and this PR approval might take long to be approved and slow down development |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Started setting up on paginator class. From previous conversations we said that this class would not be our first priority, and we might push it back to future versions in the interest of time. I had some time so I went ahead and started setting it up with the blueprint that we had spoken about. Let me know your thoughts