Fix AttributeError in PDFPageInterpreterEx by using graphicstate.ncs/scs #1008
+7
−7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR resolves a runtime error when using
pdf2zh
on certain PDF files, specifically related to incorrect access ofncs
andscs
attributes within thePDFPageInterpreterEx
class.When running the following command on macOS with Python 3.9 and LibreSSL:
pdf2zh "[Reading] Exploring the spillover effects of WeChat using graphical model.pdf" -li en -lo ko -s ollama
The following error is raised:
Cause
The
ncs
(non-stroking color space) andscs
(stroking color space) attributes are not defined directly onPDFPageInterpreterEx
but are part of the internalgraphicstate
object. This structure is consistent with the originalpdfminer.six
design. However,pdf2zh
incorrectly usesself.ncs
andself.scs
, resulting in anAttributeError
.Fix
self.ncs
andself.scs
are replaced withself.graphicstate.ncs
andself.graphicstate.scs
self.ncs = interpreter.ncs
indo_Do
are updated toself.graphicstate.ncs = interpreter.graphicstate.ncs
Result
After this fix,
pdf2zh
runs successfully and processes all pages without error:Environment
uv
Notes
pdfminer.six
's handling of color state (SCN, scn) logic