Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: fix compiling tests with beta and nightly toolchains #168

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rhysd
Copy link

@rhysd rhysd commented Nov 18, 2024

CI is failing because memchr enables missing_docs lint but some exported macros in tests are not documented.

$ cargo +nightly test
   Compiling memchr v2.7.4 (/Users/rhysd/Develop/github.com/BurntSushi/memchr)
error: missing documentation for a macro
   --> src/tests/memchr/prop.rs:9:1
    |
9   | macro_rules! define_memchr_quickcheck {
    | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
note: the lint level is defined here
   --> src/lib.rs:172:9
    |
172 | #![deny(missing_docs)]
    |         ^^^^^^^^^^^^

error: could not compile `memchr` (lib test) due to 1 previous error

This PR fixes the compile errors by allowing missing docs on the macros.

@rhysd rhysd changed the title tests: fix compiling tests with beta and nightly tests: fix compiling tests with beta and nightly toolchains Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant