Skip to content

browser-sync setOption: allow value to be undefined #1868

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

browser-sync setOption: allow value to be undefined #1868

wants to merge 1 commit into from

Conversation

milahu
Copy link

@milahu milahu commented May 7, 2021

otherwise i get TypeError: Cannot read property 'toString' of undefined

sample with patch: when the port is undefined, eleventy will say

[11ty] [Browsersync] Access URLs:
[11ty]  -------------------------------------------
[11ty]        Local: http://localhost:undefined
[11ty]     External: http://192.168.1.120:undefined

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@milahu