Conversation
|
Thanks for the PR! 🎉 We've deployed an automatic preview for this PR - you can see your changes here:
Note The build needs to finish before your changes are deployed. |
duncanuszkay-d2l
force-pushed
the
dunk.apply-button
branch
3 times, most recently
from
ca89028 to
1703061
Compare
| } | ||
| :host([_state="showing"]), | ||
| :host([_state="shown"]), | ||
| :host([_state="loading"]), |
There was a problem hiding this comment.
The shown state now represents the dirty dialog being open:
The loading state represents the loading spinner being visible:
| if (this._state === 'hidden') return nothing; | ||
| return html` | ||
| <div class="backdrop" @transitionend="${this.#handleTransitionEnd}" @transitioncancel="${this.#hide}"></div> | ||
| <div class="backdrop" @transitionend="${this.#handleTransitionEnd}" @transitioncancel="${this.#handleTransitionEnd}"></div> |
There was a problem hiding this comment.
This resolved a bug I began to run into once I adjusted the demo to allow the more rapid state changes- we can't assume that a cancellation of a transition must indicate that we need to hide, we need to check to make sure that we're in the hiding state.
| await this.shadowRoot.querySelector('d2l-empty-state-simple').getUpdateComplete(); | ||
| await this.shadowRoot.querySelector('d2l-empty-state-action-button').getUpdateComplete(); |
There was a problem hiding this comment.
This ensures that we're accurately measuring the height offset for the dialog box, this should remain consistent regardless of the text content
duncanuszkay-d2l
force-pushed
the
dunk.apply-button
branch
2 times, most recently
from
6c65b4d to
1d1bf11
Compare
duncanuszkay-d2l
force-pushed
the
dunk.apply-button
branch
3 times, most recently
from
499ce36 to
5e9287c
Compare
duncanuszkay-d2l
force-pushed
the
dunk.apply-button
branch
4 times, most recently
from
0b7aca8 to
2ae18aa
Compare
duncanuszkay-d2l
force-pushed
the
dunk.apply-button
branch
from
2ae18aa to
3663e8c
Compare
duncanuszkay-d2l
force-pushed
the
dunk.apply-button
branch
from
3663e8c to
e56e8ff
Compare
1 participant
Note for reviewers- looking for some early input on direction before finishing this up 👀
This PR is split up into commits to make it easier to review.
https://desire2learn.atlassian.net/browse/NTNGL-5471?atlOrigin=eyJpIjoiMDk2MmRlZjZmMjkxNGNhZjlmMTIxMTdiMjJiODZjODYiLCJwIjoiaiJ9
Functional Testing
Moving between the new backdrop states:
Recording.2026-04-07.163437.mp4
Using the new system in the downstream consumer (WIP integration PR)
Recording.2026-04-07.163602.mp4