Skip to content

fix: list > reduce update cycles #6634

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
GZolla wants to merge 2 commits into
base: main
Choose a base branch
from
+10 −10
Open

fix: list > reduce update cycles #6634

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
45f7c2c
fix: list > reduce update cycles
GZolla Feb 25, 2026
bdcc133
Revert pageable-mixin change
GZolla Feb 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions components/list/demo/demo-list-nested.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,8 +69,8 @@ class ListDemoNested extends LitElement {
`;
}

updated(changedProperties) {
super.updated(changedProperties);
willUpdate(changedProperties) {
super.willUpdate(changedProperties);
if (changedProperties.has('demoItemKey')) {
this._items = listDemos[this.demoItemKey] ?? [];
this._loadedItems = this._items;
Expand Down
4 changes: 2 additions & 2 deletions components/list/demo/list-item-custom.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,8 +192,8 @@ class DemoListItemCustom extends ListItemMixin(LitElement) {
return this._renderListItem(itemTemplates);
}

updated(changedProperties) {
super.updated(changedProperties);
willUpdate(changedProperties) {
super.willUpdate(changedProperties);
if (changedProperties.has('key')) {
this.label = `Label for ${this.key}`;
}
Expand Down
3 changes: 2 additions & 1 deletion components/list/list-item-expand-collapse-mixin.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,8 @@ export const ListItemExpandCollapseMixin = superclass => class extends SkeletonM
}
}

updated(changedProperties) {
willUpdate(changedProperties) {
super.willUpdate(changedProperties);
if (changedProperties.has('_siblingHasNestedItems') || changedProperties.has('expandable')) {
this._renderExpandCollapseSlot = this.expandable || this._siblingHasNestedItems;
}
Expand Down
5 changes: 2 additions & 3 deletions components/list/list.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -260,9 +260,8 @@ class List extends PageableMixin(SelectionMixin(LitElement)) {
${this._renderPagerContainer()}
`;
}

updated(changedProperties) {
super.updated(changedProperties);
willUpdate(changedProperties) {
super.willUpdate(changedProperties);
if (changedProperties.has('breakpoints') && changedProperties.get('breakpoints') !== undefined) {
Copy link
Contributor Author

@GZolla GZolla Feb 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does depend on sizing, but the resize observer handles changes in size. This means that this check only exists for the case where breakpoints change but no resizing takes place, in which case using willUpdate is appropriate.

this.resizedCallback(this.offsetWidth, true);
}
Expand Down
4 changes: 2 additions & 2 deletions components/paging/pageable-mixin.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,8 @@ export const PageableMixin = superclass => class extends CollectionMixin(supercl
});
}

firstUpdated(changedProperties) {
super.firstUpdated(changedProperties);
connectedCallback() {
super.connectedCallback();
this._updateItemShowingCount();
}

Expand Down
Loading