Conversation
|
Thanks for the PR! 🎉 We've deployed an automatic preview for this PR - you can see your changes here:
Note The build needs to finish before your changes are deployed. |
components/colors/colors.js
Outdated
| --d2l-opacity-disabled-link: 0.74; | ||
| --d2l-opacity-disabled-linkicon: 0.64; | ||
|
|
||
| --d2l-shadow-attached-color: rgba(0, 0, 0, 0.03); |
There was a problem hiding this comment.
Also note: these lower level values are mapped from Figma, but it remains to be decided whether we actually want them in the code. We may just want --d2l-shadow-attached, --d2l-shadow-floating, and --d2l-shadow-inset.
| --d2l-color-background-default: #ffffff; | ||
| --d2l-color-border-medium: var(--d2l-color-mica); | ||
| --d2l-color-font-base: var(--d2l-color-ferrite); | ||
| --d2l-sem-background-color-base: #ffffff; |
There was a problem hiding this comment.
We've made a bunch of changes... curious what you/others think of the semantic names.
Of note:
- Added the
-sem-qualifier clearly identify our semantic variables and avoid any confusion or conflict. Both Jeff and I would also be onboard with-s-in effort to shorten if others want. - The
-background-is now included per Dave L's previous inquiry about what the colors were for. We could abbreviate to-bg-if people want, but we're not abbreviatingborderet al. so 🤷♂️ . - The
-color-is now included to enable us to add non-color variables for spacing and radius later.
I'm not sure how difficult it would be on the Figma side, but we might be able to flip things from --d2l-sem-background-color-elevated to --d2l-sem-elevated-background-color. Can consider that if people want.
…tspaceUI/core into dbatiste/initial-dark-mode-palette
|
I'll be closing this PR in lieu of individual PRs to update components and include visual-diffs for them. |
GAUD-9068
Just posting this draft PR for anyone who wants to see the palette as of yesterday. Extracted from Figma, with colors resolved to the existing color variables where possible. I only generated variables for colors so far. I'll be trying to apply these to a couple of components.