Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Investment Funds API #528

Open
wants to merge 14 commits into
base: main
Choose a base branch
from

Conversation

alanmareines
Copy link

API Fundos de Investimento

[CVM] Dados Cadastrais

Criação de uma API que busca dados cadastrais de fundos de investimento na CVM, em sua planilha de Dados Cadastrais diários.

Feature

Foram adicionadas duas rotas (seguindo padrão do endpoint de corretoras):

  • GET cvm/fundos/v1?page=1&size=100 - busca por todos fundos já registrados na CVM - paginação implementada pelo tamanho da planilha.
  • GET cvm/fundos/v1/:cnpj - Detalhes de dados de um fundo específico.

Testes

Foram criados 3 testes e2e para assegurar o funcionamento dos endpoints criados.

Documentação

Documentação também foi atualizada e testada na UI já implementada

@vercel
Copy link

vercel bot commented Oct 20, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
brasilapi ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 22, 2024 0:22am

RodriAndreotti
RodriAndreotti previously approved these changes Oct 20, 2023
Copy link
Collaborator

@RodriAndreotti RodriAndreotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Parabéns pelo PR, Mestre!

@alanmareines
Copy link
Author

Boa! Aguardando o merge do #530 para realizar o rebase.

pages/docs/doc/fundos.json Outdated Show resolved Hide resolved
services/cvm/fundos.js Outdated Show resolved Hide resolved
services/cvm/fundos.js Outdated Show resolved Hide resolved
tests/fundos-v1.test.js Outdated Show resolved Hide resolved
@alanmareines
Copy link
Author

@LorhanSohaky, estou trabalhando em paralelo em um PR para os testes que estão flaky. Conseguimos rodar o pipe de novo?

@RodriAndreotti
Copy link
Collaborator

Para rodar o pipe

@LorhanSohaky, estou trabalhando em paralelo em um PR para os testes que estão flaky. Conseguimos rodar o pipe de novo?

Para rodar o pipe acho que só fazendo um novo commit (nem que seja com uma adicional)

LorhanSohaky
LorhanSohaky previously approved these changes Oct 28, 2023
Copy link
Member

@LorhanSohaky LorhanSohaky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Muito obrigado pela contribuição

@sonarcloud
Copy link

sonarcloud bot commented Oct 29, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@alanmareines
Copy link
Author

Agora vai 😅

Copy link

sonarcloud bot commented Dec 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@alanmareines
Copy link
Author

Atualizando a branch com main... @RodriAndreotti @lucianopf @murilohns

const parsedData = parseCvmData(fundData, { summary: true });

return {
data: parsedData.slice((offset - 1) * pageSize, offset * pageSize),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Será que faz sentido carregarmos todo o dataset para fazermos uma paginação virtual?

Copy link

sonarcloud bot commented Feb 22, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants