Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug so max_retries can be overridden to zero in message options #646

Merged

Conversation

chrisittner
Copy link
Contributor

Hi 👋,

small bugfix for the following issue that I stumbled over:

@dramatiq.actor(max_retries=99)
def do_work():
    raise Exception("attempt failed")

do_work.send_with_options(max_retries=0)

-> do_work will be retried 100 times instead of once, even though message options should override actor options.

@Bogdanp
Copy link
Owner

Bogdanp commented Aug 22, 2024

Thanks! Can you fix the lint issue when you have a moment? I'll go ahead and merge after.

@chrisittner chrisittner force-pushed the bugfix-make-retries-overridable-to-zero branch from 7626e58 to 2716a8d Compare August 22, 2024 15:34
@Bogdanp Bogdanp merged commit 9ac9b26 into Bogdanp:master Aug 22, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants