Add library support for adding modules to components #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a target field to config, which defines the field to add the given values to.
VeryMilkyJoe
force-pushed
the
add-module-support
branch
from
1459fbf
to
6f9a783
Compare
|
Sorry, I'm short on time at the moment. I skimmed through, seems fine overall, thanks! I'll review again once you get CI green. |
VeryMilkyJoe
force-pushed
the
add-module-support
branch
from
6f9a783
to
5f8fbe8
Compare
|
Great, thank you! |
Bodigrim
reviewed
Oct 19, 2024
VeryMilkyJoe
force-pushed
the
add-module-support
branch
from
5f8fbe8
to
759cb88
Compare
I made all the changes you requested and also took care of the warnings in the new test-suite, thank you for the quick review! |
…xisting modules in target field are separated by spaces instead of commas Add tests which verify correct behaviour
VeryMilkyJoe
force-pushed
the
add-module-support
branch
from
759cb88
to
f51e917
Compare
|
Thanks a ton! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a target field to the config, which defines the field of the component to add the given values to.
The algorithms now adds values to the target field instead of always adding to
build-depends.The
executeConfigfunction can now be configured to add to different fields while the cli tool will still always use execute config forbuild-depends.This would be very useful for HLS, as we want to use
cabal-addas a library to be able to offer code actions to add unknown modules to cabal files in a project.Added some tests, verifying that modules can be added correctly with the right config.
If the previously written modules are separated by a space, instead of a comma, we currently don't extend accordingly, this is reflected in a test which currently fails.