Patch/kangarang factory tests #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add code to prevent transferring to the 0x0 address, and the contract address, according to Token Implementation Best Practices. Reference: https://consensys.github.io/smart-contract-best-practices/tokens/
Added short comments
Added SafeEIP20 that inherits from EIP20 and prevent transferring tokens to 0x0 and contract address. EIP20Factory is changed to use SafeEIP20. Reverted EIP20 to its state before the pull request created. JavaScript Truffle Tests are writen for SafeEIP20.
Modify Function Declaration to follow Solidity Style Guide: https://solidity.readthedocs.io/en/v0.3.1/style-guide.html
Encapsulated EIP compatible functions' tests inside a function and make it called for both EIP20 and SafeEIP20 smart contracts.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.