Code quality #1773
Open
Code quality #1773
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PeterSurda
added
the
developers
g1itch
reviewed
Jun 2, 2021
| @@ -21,7 +21,7 @@ class UDPSocket(BMProto): # pylint: disable=too-many-instance-attributes | |||
| port = 8444 | |||
|
|
|||
| def __init__(self, host=None, sock=None, announcing=False): | |||
| # pylint: disable=bad-super-call | |||
| # pylint: disable=bad-super-call, access-member-before-definition | |||
| super(BMProto, self).__init__(sock=sock) | |||
There was a problem hiding this comment.
super(UDPSocket, self).__init__(sock=sock)?
g1itch
reviewed
Aug 9, 2021
| @@ -97,22 +97,30 @@ def bm_command_addr(self): | |||
| time.time() | |||
| return True | |||
|
|
|||
| # override the protocol do ignore the following commands on UDP | |||
| # we do this mainly for security reasons | |||
There was a problem hiding this comment.
This is more of inheritance flow. Maybe UDPSocket should inherit from some more basic class?
g1itch
reviewed
Aug 9, 2021
| @@ -21,7 +21,7 @@ class UDPSocket(BMProto): # pylint: disable=too-many-instance-attributes | |||
| port = 8444 | |||
|
|
|||
| def __init__(self, host=None, sock=None, announcing=False): | |||
| # pylint: disable=bad-super-call | |||
| # pylint: disable=bad-super-call, access-member-before-definition | |||
There was a problem hiding this comment.
This is a bug: pylint-dev/pylint#2315
There was a problem hiding this comment.
The linked bug has been fixed. The ignore shouldn't be needed anymore.
PeterSurda
force-pushed
the
cq101
branch
2 times, most recently
from
fde350b
to
e8732f4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A couple of code quality fixes.