-
Notifications
You must be signed in to change notification settings - Fork 577
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added flatpak build manifests with split dependencies #1768
base: v0.6
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update documentation
Also, I don't get a point of documenting the maintenance tasks in such way. Why don't you just make a script There supposed to be a builder on |
@g1itch I'm working on the buildbot integration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Clean up, rebase and then I'll look at it again.
07316eb
to
a9d9356
Compare
# PyBitmessage Linux flatpak instructions | ||
|
||
## Requirements | ||
First make sure you have `flatpak` and `flatpak-builder` installed along with these dependencies (Ubuntu 20.4) `git xz-utils elfutils librsvg2-common` needs to be installed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
line too long
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As it is a readme file, I don't think there would be any pylint line too long warning will happen.
Please confirm if still I need to break it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't have a strong opinion so we can probably just leave it as it is.
48ee56a
to
eaadcf0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can merge it, the buildbot integration can be deployed later.
# PyBitmessage Linux flatpak instructions | ||
|
||
## Requirements | ||
First make sure you have `flatpak` and `flatpak-builder` installed along with these dependencies (Ubuntu 20.4) `git xz-utils elfutils librsvg2-common` needs to be installed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't have a strong opinion so we can probably just leave it as it is.
26216cb
to
1753c97
Compare
9b95345
to
bfa611b
Compare
57b05f9
to
e607cda
Compare
0036dcd
to
2ce0698
Compare
d0f73d0
to
f4edee1
Compare
73d8238
to
d42f807
Compare
c1d6e7d
to
0a718dc
Compare
65ef4bb
to
475dca3
Compare
Removed extra lines from build sequence Added Dockerfile for Flatpak repo-server & Build instructions under docs/ dir Modified Dockerfile & Flatpak build doc updated docs fixed code quality issues fixed code quality, added doc string fixed branch & added build commands run setuptools fixed code quality refactor pip install updated flatpak build doc & added link to index.rst Removed extra lines from build sequence Added Dockerfile for Flatpak repo-server & Build instructions under docs/ dir Modified Dockerfile & Flatpak build doc updated docs fixed code quality issues fixed code quality, added doc string fixed branch & added build commands run setuptools fixed code quality refactor pip install updated flatpak build doc & added link to index.rst fixed docs rebased removed unnecessary files removed .gitmodules: should be part of build process
Added Flatpak build manifests under
packages/flatpak/
directoryAdded Flatpak build instructions under
docs/
directory