Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

name replaced by person as deprecated #405

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

pierrelouisdelx
Copy link
Contributor

faker.name is deprecated since v8.0 and will be removed in v10.0.
It is replaced by faker.person

@changeset-bot
Copy link

changeset-bot bot commented Jun 15, 2023

⚠️ No Changeset found

Latest commit: e5b26a8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@BitPhinix
Copy link
Owner

For this to work, I think you'd need to bump the package as well 🤔

Signed-off-by: Pierre-Louis Delcroix <[email protected]>
@pierrelouisdelx
Copy link
Contributor Author

I've just updated the package !

Signed-off-by: Pierre-Louis Delcroix <[email protected]>
@pierrelouisdelx
Copy link
Contributor Author

Do you have any idea why the linter is failing ? I've just changed faker js in package.json

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants