Added new TriangularPrism shape primitive, fixed bug in the OctahedronMesh class #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nMesh class Added a new TriangularPrism 3D shape primitive. Fixed a bug in the OctahedronMesh class.
…ouble'
bug fix by Yehya BELHAMRA {[email protected]} {http://www.yahiab.com}
the bug was in the getMajorRadius() and getMinorRadius(), its return type was Double, which caused an exception when trying to export this shape as FXML file using the FXMLExporter.java class from the OpenJFX project.
Its return type should be a 'double', the primitive type, and not 'Double'.
travisfw
pushed a commit
to travisfw/FXyz
that referenced
this pull request
Aug 23, 2020
fixes issue Birdasaur#8 (Mesh2CSG functionality)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a new TriangularPrism 3D shape primitive.
Fixed a bug in the OctahedronMesh class.