Release Automation #264
Open
Release Automation #264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yulric
requested changes
Oct 30, 2023
R-package/R/osf-interactions.R
Outdated
| dictionary) | ||
|
|
||
| # Download previous release dictionary | ||
| past_dictionary_path <- download_dictionary(past_dictionary_path, OSF_TOKEN, OSF_REPO_LINK, odm_dictionary$tmp_dictionary_directory_past_release, origin_directory = "Current Release") |
There was a problem hiding this comment.
This and the next lines which parses the dictionary should be pulled into a function that downloads and parses the currently released dictionary from osf. Would also be used in the create_release_files function.
R-package/R/osf-interactions.R
Outdated
| #' | ||
| #' @param OSF_TOKEN The OSF token used to authenticate the user. | ||
| #' @param OSF_LINK The OSF link to the main repo. | ||
| archive_previous_release <- function(OSF_TOKEN, OSF_LINK, past_dictionary_version){ |
There was a problem hiding this comment.
Should be split into functions. Once which creates the archive and one which uploads the new release.
R-package/R/osf-interactions.R
Outdated
| #' @param files_to_extract A list of files to extract. | ||
| #' @param dictionary The dictionary file. | ||
| #' | ||
| stage_osf_files <- function(files_to_extract, |
There was a problem hiding this comment.
Isn't this function essentially the same as the create_files function.
yulric
changed the title
…lso renamed the file
…Lab/PHES-ODM into automation-integration
…he workflow file.
* Files
* R-package/R/odm-dictionary-file.R: Moved the log file path to the
new logging module.
* R-package/R/logging.R: The new logging module.
* R-package/R/create-release-files.R:
* Use the new setup_logging function.
* Display the log file path when in the warning message for
build errors.
* R-package/R/osf-interactions.R
* Use the new setup_logging function
The get_dictionary function used to assume that there would be multiple dictionaries downloaded from OSF which is unnecessary. The dictionary_path is now the full path to the downloaded dictionary rather than a folder that could contain multiple dictionaries. The download_dictionary function now returns the full path to the dictionary rather than the folder to where it's downloaded.
…e variable template_variables$version. Refactored code to use this.
…sheets. It now uses a column from a new sets sheet module.
…sheet module. Added new module called parts-sheet to contain columns for the parts sheet
…th booleans were giving the same inforamtion. Updated the references.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contains user guides as well as the latest github actions and code for automation.
User guides and code changes are found within the R-package directory and the new action files are found within github/workflows directory.