Improve usage of OIDC_TLS_VERIFY #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When OIDC_TLS_VERIFY was set to the string "true" this was converted to the boolean `true` by `strToBool`. This resulted in `skipTLSVerify` also returning `true`. Thus verification was actually skipped. Fixed this inverted logic bug.
The configuration OIDC_TLS_VERIFY was only applied to for the refresh- token related checks. It was still not possible to use the test client with an OIDC provider that was using a self-signed certificate. This commit changes the context used for communicating with the OIDC provider. That way TLS certificate validation can be skipped and thus an OIDC provider using a self-signed certificate can also be used.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When trying to use the oidc-test-client with an OIDC provider running locally behind a self-signed certificate I ran into two minor issues. Created two small commits to fix those.