Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dhcp: fix scope moving when it shouldn't #1318

Merged
merged 1 commit into from
Nov 25, 2024
Merged

Conversation

BeryJu
Copy link
Owner

@BeryJu BeryJu commented Nov 25, 2024

closes #1269

Copy link

netlify bot commented Nov 25, 2024

Deploy Preview for beryju-gravity ready!

Name Link
🔨 Latest commit 2e8fd6c
🔍 Latest deploy log https://app.netlify.com/sites/beryju-gravity/deploys/6743ed02f67d7c0008bce254
😎 Deploy Preview https://deploy-preview-1318--beryju-gravity.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 69
Accessibility: 88
Best Practices: 92
SEO: 77
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Nov 25, 2024

Bundle Report

Bundle size has no change ✅

Copy link

codecov bot commented Nov 25, 2024

Codecov Report

Attention: Patch coverage is 37.50000% with 5 lines in your changes missing coverage. Please review.

Project coverage is 61.18%. Comparing base (0a66b6d) to head (2e8fd6c).
Report is 1 commits behind head on main.

❌ We are unable to process any of the uploaded JUnit XML files. Please ensure your files are in the right format.

Files with missing lines Patch % Lines
pkg/roles/dhcp/scopes.go 37.50% 4 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1318      +/-   ##
==========================================
+ Coverage   61.15%   61.18%   +0.02%     
==========================================
  Files         108      108              
  Lines        6125     6132       +7     
==========================================
+ Hits         3746     3752       +6     
- Misses       2030     2031       +1     
  Partials      349      349              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BeryJu BeryJu merged commit 6272435 into main Nov 25, 2024
16 of 18 checks passed
@BeryJu BeryJu deleted the dhcp/fix-scope-moving branch November 25, 2024 03:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DHCP changed request scope
1 participant