Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

instance: protobuf migration v2 #1315

Merged
merged 2 commits into from
Nov 26, 2024
Merged

instance: protobuf migration v2 #1315

merged 2 commits into from
Nov 26, 2024

Conversation

BeryJu
Copy link
Owner

@BeryJu BeryJu commented Nov 25, 2024

smaller version of #460

Copy link

netlify bot commented Nov 25, 2024

Deploy Preview for beryju-gravity ready!

Name Link
🔨 Latest commit a82dbe6
🔍 Latest deploy log https://app.netlify.com/sites/beryju-gravity/deploys/6743e5faa05a980008e1b394
😎 Deploy Preview https://deploy-preview-1315--beryju-gravity.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 71
Accessibility: 88
Best Practices: 92
SEO: 77
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Nov 25, 2024

Bundle Report

Bundle size has no change ✅

Copy link

codecov bot commented Nov 25, 2024

Codecov Report

Attention: Patch coverage is 55.05618% with 40 lines in your changes missing coverage. Please review.

Project coverage is 61.06%. Comparing base (a996006) to head (a82dbe6).
Report is 15 commits behind head on main.

❌ We are unable to process any of the uploaded JUnit XML files. Please ensure your files are in the right format.

Files with missing lines Patch % Lines
pkg/roles/tsdb/types/role_tsdb_record.pb.go 53.84% 28 Missing and 2 partials ⚠️
pkg/roles/tsdb/api.go 37.50% 5 Missing ⚠️
pkg/roles/tsdb/role.go 66.66% 2 Missing and 1 partial ⚠️
pkg/tests/utils.go 71.42% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1315      +/-   ##
==========================================
- Coverage   61.57%   61.06%   -0.52%     
==========================================
  Files         107      109       +2     
  Lines        6080     6208     +128     
==========================================
+ Hits         3744     3791      +47     
- Misses       1988     2064      +76     
- Partials      348      353       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BeryJu BeryJu merged commit 0881994 into main Nov 26, 2024
16 of 18 checks passed
@BeryJu BeryJu deleted the instance/protobuf-v2 branch November 26, 2024 01:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant