Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Note 2014 LTE Android 5.1.1 #373

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Note 2014 LTE Android 5.1.1 #373

wants to merge 2 commits into from

Conversation

Toxantron
Copy link

@Toxantron Toxantron commented Nov 6, 2016

By merging sshimko into master I was able to flash TWRP 3.0.2 and install CM-13.0.

sshimko and others added 2 commits September 5, 2014 10:36
Default parameter values in SendPacket and ReceivePacket
were leading to confusion in the ReceivePit function.
Empty transfer flags were passed in as timeouts.

Additionally, on the GS5, empty transfers
aren't required around the send ack packets
during Pit retrieval, and actually screw up
the state breaking the remainder of
the session.
This was referenced Nov 6, 2016
@Toxantron
Copy link
Author

By reading through the commits sometime around 2014 you included an empty packet into the USB as a bugfix. I am starting to think this was actually a bug introduced by samsung engineers accidentally. They realized a little later and fixed it. Because if you use -v you can see each of this calls fails. So this is not really a fix, it simply supresses the error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants