Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Achievement 'fix'. #11958

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Therealdoooc213
Copy link
Contributor

About The Pull Request

Previously, achievements would announce with to_chat, which would announce their achievement to everyone, including people on the menu. This includes LETS PLAY GLOBAL THERMONUCLEAR WAR, the achievement nukies get upon declaring war for the first time.

Why It's Good For The Game

Prevents people on the menu from metagaming?

Testing Photographs and Procedure

Screenshots&Videos

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

Not really any good way to test this, view code.

Changelog

🆑
tweak: achievements no longer announce to people playing on the menu.
/:cl:

@Therealdoooc213 Therealdoooc213 changed the title Achievement fix Achievement fix. Nov 30, 2024
@Marshmellow105
Copy link
Contributor

leave my sovl alone

you can already metagame warops when everyone has AA and it is red alert 5 minutes into the round

@Therealdoooc213
Copy link
Contributor Author

leave my sovl alone

you can already metagame warops when everyone has AA and it is red alert 5 minutes into the round

You are mad because you cant handle me. You cant handle me because I'm above you. I'm above you because I'm better. I'm better.

@Therealdoooc213 Therealdoooc213 changed the title Achievement fix. Achievement 'fix'. Nov 30, 2024
@Hardly3D
Copy link
Contributor

You don't know how soulful it is to hear a massive explosion and see "G-ghosts?" show up on the chat

@TwingoI
Copy link

TwingoI commented Nov 30, 2024

You can actually tell if nukies spawn without warops roundstart, just dont ready up and if you hear the piece of paper equip sfx that means nukies rolled

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants