Dionae changes #11905
Open
Dionae changes #11905
+10
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PowerfulBacon
requested changes
Dec 3, 2024
| if(!LAZYLEN(limbs_to_heal)) | ||
| return | ||
| playsound(H, 'sound/creatures/venus_trap_hit.ogg', 25, 1) | ||
| toggle_ai(AI_OFF) | ||
| if(!do_after(arrived_diona, 5 SECONDS, source, progress = TRUE)) |
There was a problem hiding this comment.
This proc doesn't have the SIGNAL_HANDLER define in error. If you add it you will find that this line fails because signal handlers shouldn't be sleeping as they cause unpredictable behaviour. You will need to mark this proc as a signal handler and either call this behaviour asynchronously or set the proc to waitfor false.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Some basic gameplay changes for dionae, requested by Ruko and Bacon.
Why It's Good For The Game
Having oversights is bad
Testing Photographs and Procedure
Screenshots&Videos
Put screenshots and videos here with an empty line between the screenshots and the
<details>tags.Changelog
🆑 XeonMations
balance: Dionae now take 5 seconds to assimilate nymphs on the ground.
/:cl: