Ports typing indicators using your bubble icon from tgstation

[Miliviu]

About The Pull Request

Ports tgstation/tgstation#67872
Now the Typing Indicator uses your bubble icon
Closes #4895

Why It's Good For The Game

We get back the cool Lawyer and other bubble indicators and I mean @Fresh341 really wanted the badge to work again!

Testing Photographs and Procedure

Screenshots&Videos

Video showing the new Lawyer typing indicator and the normal one with the Psychozia for no reason at all!

2024-01-07.18-24-00.mp4

Changelog

🆑Crumpaloo, jlsnow301, JohnFulpWillard, Miliviu
add: Typing indicators now use your speech bubble type, rather than all being the same, so Lawyers have that cool speech bubble again.
/:cl:

[itsmeow]

I'm not sure that this is a good idea. What if the player's job or species is obscured in some way and they start typing, meta-exposing them?

[Miliviu]

I'm not sure that this is a good idea. What if the player's job or species is obscured in some way and they start typing, meta-exposing them?

I don't know, it's something that you can already can see if you disable Runechat (bubble_icons), so, If it wasn't an issue before I'd be weird if it was an issue today, right?

[itsmeow]

Because nobody disables them, and they haven't been around for everyone since the server's LRP days.

[JixS4v]

Isn't this just tied to the badge? People can still remove it

[Miliviu]

It's not just the badge there are some more, let me check if any of them is problematic!

[JixS4v]

You can still tell someone's species by just checking the flavourtext like "blorbles", "meows", "hisses"

[Miliviu]

1. We have the default bubbles, no issue with them
2. Then Alien and Alien Royale, there is no way or need to obscure that afaik
3. Machine is used by silicons, I don't know how a borg or a Silicon could try to obscure their state as borgs
4. Syndiborgs, this one kinda concerns me, Is there a way to obscure your Syndicate Status as a borg?
5. The rest of em are for like, Clockcult Scarabs, swarmers...
6. Finally the lawyer, you can just remove the badge and tadaa

SO, if a Syndie Cyborg uses chameleon their buble icon changes to normal Cyborg

[Miliviu]

BeeStation-Hornet/code/modules/antagonists/nukeop/equipment/borgchameleon.dm

Lines 85 to 93 in 87794d6

	/obj/item/borg_chameleon/proc/activate(mob/living/silicon/robot/user)
	START_PROCESSING(SSobj, src)
	src.user = user
	savedName = user.name
	user.name = friendlyName
	user.module.cyborg_base_icon = disguise
	user.bubble_icon = "robot"
	active = TRUE
	user.update_icons()

[Miliviu]

So, honestly, I think there isn't a case where this can "reveal" your Species, Traitor Status, etc

[Tsar-Salat]

There are enough tells to see someone's species, especially ones more obvious than speech, that I don't think it'll be an issue.

[itsmeow]

This won't work with blindness

[Miliviu]

It'll not?

[itsmeow]

No, looking at the code you haven't set the planes and layers properly or updated the blindness indicator at all

[Miliviu]

I'll draft this and take a peak asap!

[itsmeow]

More specifically, the old indicators have these planes/layers:

[Miliviu]

This doesn't do it? @itsmeow

[itsmeow]

Did you.. test it?

[Miliviu]

I only tested it without blind people oops, aaand you were right, it breaks it, I'll fix it asap

[Miliviu]

Errr, I lost interest on this, I need to figure it out with blind code, whenever I feel like doing it I'll reopen the PR!