feat: file upload (minio, s3, frontend...) #443

yoannfleurydev · 2024-01-12T16:25:18Z

Describe your changes

closes #<issue_id>

Simplified version of the Avatar Upload process :

Notes :

To upload a file in a different folder on the bucket, the path should be included in the key of the file

Left to do / Lines of thought

How do we handle upload of sensitive files (i.e with restricted access) ? Because currently, the files uploaded are public and the url is permanent.
How do we keep track (on the server) of the different files uploaded ?
Summarize the existing logic for a better understanding
There is currently no way of deleting a file from the Frontend

Simplify, clean and remove unused parts to get the existing part working and as simple as possible. (For know, just focus on public file upload for avatars and we'll see later for the rest.
Rebase to get the React-hook-form update
Update the fields

Screenshots

Documentation

Checklist

I performed a self review of my code
I ensured that everything is written in English
I tested the feature or fix on my local environment
I ran the pnpm storybook command and everything is working
If applicable, I updated the translations for english and french files
(If you cannot update the french language, just let us know in the PR description)
If applicable, I updated the README.md
If applicable, I created a PR or an issue on the documentation repository
If applicable, I’m sure that my feature or my component is mobile first and available correctly on desktop

vercel · 2024-01-12T16:25:24Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
start-ui	❌ Failed (Inspect)			May 13, 2024 3:05pm

sonarcloud · 2024-01-12T16:25:49Z

Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

1 New issue
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

ntatoud · 2024-04-08T16:17:43Z

TODO :

Upload multiple files ??
Verify file types => Any file can be uploaded as an avatar
Maybe improve README with new modifications ?

ntatoud · 2024-05-06T13:43:12Z

Here is the idea for the refactor I did in commit : refactor(file-upload): Remove hook abstraction layer and regroup feature's files
…

src/files/utils.ts

DecampsRenan · 2024-05-06T15:52:12Z

src/files/utils.ts

+ >
+ ) =>
+ async (
+ file?: File,


why the file is optional ? can we make it required ? (I don't see a use case where we call uploadFile without a file ^^)

We have to check at one point if the file retrieved from the form is empty or not.
The choice was made to handle the 'file is undefined' case in this function but could be moved in the form, before making the call to the mutation ?

Let me know what you think is best ?

src/server/config/s3.ts

src/features/account/AccountProfileForm.tsx

# Conflicts: # docker-compose.yml

tested with R2 from Cloudflare # Conflicts: # .env.example

…ure's files

sonarcloud · 2024-05-13T15:05:56Z

Quality Gate passed

Issues
5 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

ntatoud · 2024-05-13T16:41:42Z

src/components/Form/FieldUpload/FieldUpload.spec.tsx

+
+ // Here we can use '!' on mockFile.name to prevent TS error because we are sure it is defined
+ const input = screen.getByLabelText<HTMLInputElement>(mockFile.name!);
+ await user.upload(input, mockFile.file ?? []);


Reminder : Remove this line, it was copy pasted from the other test and should not be here

vercel bot had a problem deploying to Preview January 12, 2024 16:25 Failure

yoannfleurydev mentioned this pull request Jan 12, 2024

Upload files #431

Closed

ntatoud force-pushed the feat/upload-files-minio-s3 branch from 0305a22 to 2ec53e9 Compare April 8, 2024 16:04

vercel bot had a problem deploying to Preview April 8, 2024 16:06 Failure

vercel bot had a problem deploying to Preview May 6, 2024 12:52 Failure

ntatoud force-pushed the feat/upload-files-minio-s3 branch from bfda1a2 to 88c14de Compare May 6, 2024 13:15

vercel bot had a problem deploying to Preview May 6, 2024 13:16 Failure

vercel bot had a problem deploying to Preview May 6, 2024 13:50 Failure

DecampsRenan requested changes May 6, 2024

View reviewed changes

vercel bot had a problem deploying to Preview May 10, 2024 13:58 Failure

ivan-dalmet and others added 16 commits May 10, 2024 16:05

wip: Upload file

ef1f9d4

wip: docker compose for minio

7400350

# Conflicts: # docker-compose.yml

wip: add postgres to docker compose

85a60be

wip: improve env var and docker compose

0445854

tested with R2 from Cloudflare # Conflicts: # .env.example

wip: configurable key

7b6305a

wip: add image direct upload component

261017d

add healthcheck to minio making sure it is up to create bucket

ce698c4

wip: improve rights on the minio setup

b228fc5

feat: Add FieldUploadPreview component on AccountProfileForm

4333354

feat: add optional user metadata on signedUrl S3 calls

15b41b1

remove ACL, implement getSignedUrl, minio env variables

fb35492

feat: improve file uploads + useAvatarUpload and useFileUpload hooks

16a7521

fix: change POST http word by GET to get presigned urls

ca73dca

feat: fetch avatar in front-end to get metadata

818b68f

wip: FieldUploadPreview example in Storybook

6e89e38

fix: docker version minio and example order

9a46ee1

ntatoud added 4 commits May 10, 2024 16:12

refactor(file-upload): Remove hook abstraction layer and regroup feat…

32eb2fe

…ure's files

fix(file-upload): Remove unused code to simplify

fec2d82

fix(file-upload): Feedback + more simplifcation

212ef85

wip: refactor(file-upload): with react-hook-form

48a85ea

ntatoud force-pushed the feat/upload-files-minio-s3 branch from 4352848 to 48a85ea Compare May 13, 2024 10:37

vercel bot had a problem deploying to Preview May 13, 2024 10:38 Failure

fix(file-upload): clean zod schema + file type validation

2af4659

vercel bot had a problem deploying to Preview May 13, 2024 12:17 Failure

ntatoud added 2 commits May 13, 2024 15:42

docs(file-upload): Update docs.stories for RHF FieldUpload

1f2d2c0

test(file-upload): Vitest update and default value for FieldUpload

6918a7f

vercel bot had a problem deploying to Preview May 13, 2024 13:46 Failure

ntatoud added 2 commits May 13, 2024 16:56

refactor(file-upload): move avatar file check before call to mutation

344ff74

feat(file-upload): FieldUploadPreview with RHF

6802450

vercel bot had a problem deploying to Preview May 13, 2024 14:58 Failure

fix(file-upload): Delete previous Formiz FieldUpload

d782eda

vercel bot had a problem deploying to Preview May 13, 2024 15:05 Failure

ntatoud reviewed May 13, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: file upload (minio, s3, frontend...) #443

feat: file upload (minio, s3, frontend...) #443

yoannfleurydev commented Jan 12, 2024 •

edited by ntatoud

vercel bot commented Jan 12, 2024 •

edited

sonarcloud bot commented Jan 12, 2024

ntatoud commented Apr 8, 2024

ntatoud commented May 6, 2024

DecampsRenan May 6, 2024

ntatoud May 13, 2024

sonarcloud bot commented May 13, 2024

ntatoud May 13, 2024

feat: file upload (minio, s3, frontend...) #443

Are you sure you want to change the base?

feat: file upload (minio, s3, frontend...) #443

Conversation

yoannfleurydev commented Jan 12, 2024 • edited by ntatoud

Describe your changes

Left to do / Lines of thought

Screenshots

Documentation

Checklist

vercel bot commented Jan 12, 2024 • edited

sonarcloud bot commented Jan 12, 2024

Quality Gate passed

ntatoud commented Apr 8, 2024

ntatoud commented May 6, 2024

DecampsRenan May 6, 2024

Choose a reason for hiding this comment

ntatoud May 13, 2024

Choose a reason for hiding this comment

sonarcloud bot commented May 13, 2024

Quality Gate passed

ntatoud May 13, 2024

Choose a reason for hiding this comment

yoannfleurydev commented Jan 12, 2024 •

edited by ntatoud

vercel bot commented Jan 12, 2024 •

edited