fix: default focus on login page #406
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@arinchaik is attempting to deploy a commit to the Team Bearstudio Team on Vercel. A member of the Team first needs to authorize it. |
|
Kudos, SonarCloud Quality Gate passed!
|
FabienEssid
suggested changes
Aug 16, 2023
| @@ -49,6 +49,7 @@ export const LoginForm = ({ | |||
| label={t('auth:data.username.label')} | |||
| required={t('auth:data.username.required')} | |||
| formatValue={(v) => v?.toLowerCase().trim()} | |||
| autoFocus | |||
There was a problem hiding this comment.
Be careful, in the issue it is written "not on a mobile device", I'm not sure autoFocus runs only on desktop mode
Chakra UI provides you ways to know on which device you are running the app using useBreakpointValue hook. There is an example of this hook in DateSelectorPicker component
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
closes #336
Screenshots