added time encoder #912
Draft
added time encoder #912
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @07pepa , |
07pepa
force-pushed
the
add-time-endoder
branch
2 times, most recently
from
36be7ab
to
47a6c77
Compare
pepe-rtmlab
reviewed
Apr 19, 2024
|
Hi @07pepa , |
07pepa
force-pushed
the
add-time-endoder
branch
8 times, most recently
from
8087d7c
to
b0e59ae
Compare
|
lets wait how pydantic will resolve this here pydantic/pydantic#9571 |
|
Riverfount
previously approved these changes
Jul 2, 2024
|
@Riverfount there is preaty nasty bug in pydantic/pydantic#9571 we should wait how they resolve it IMHO it would be bad if implementation would differ from theirs and it currently does and bypasses pydantic |
|
@Riverfount can you remove you approve ? i know this is not usual request... but... in this case is better to wait |
|
This PR is stale because it has been open 45 days with no activity. |
|
This PR is stale because it has been open 45 days with no activity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have added time encoded however i suspect there may be issue in pydantic ( speed date) itself see pydantic/speedate#62