Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing type hint and correct return for asynchronous update like (Document.find().inc() #909

Closed
wants to merge 14 commits into from
Closed

Fixing type hint and correct return for asynchronous update like (Document.find().inc() #909

wants to merge 14 commits into from

Conversation

CAPITAINMARVEL
Copy link

No description provided.

Maxim Borisov and others added 12 commits February 29, 2024 11:41
Annotate decorators that wrap Document methods (#679)
7f8f92a 
Type checkers were complaining about missing `self`
argument in decorated `Document` methods. This was
caused by incomplete annotations of used decorators.
fixup! Annotate decorators that wrap Document methods (#679)
64b7790 
Removed sync/async overload in favour of ignoring errors in wrappers
because mypy confused them and always expected async function.
@CAPITAINMARVEL
fix type hint aggregation_methods and overload for update on interfac…
52334d1 
…e type hinting
@CAPITAINMARVEL
fixed UnionDoc missing from find interface and init beanie
e02525c
@CAPITAINMARVEL
fix type hint distinct, sort, expressions, args from find interface, …
b57196b 
…datetime for current_date
@CAPITAINMARVEL
fix type hint for inc, set, current_date
9c81084
@CAPITAINMARVEL
fix return type
676fd5e
@CAPITAINMARVEL
fix overload mistake with Self
3f7233e
@CAPITAINMARVEL
fix pymongo_kwargs type hint unknown
a0bd1b6
@CAPITAINMARVEL
fix type hint kwargs
dc9b439
@CAPITAINMARVEL
fix type hint update and one missing
6dcb87d
@CAPITAINMARVEL
fix typo pymongo_kwargs
9f9b805
@CAPITAINMARVEL
Copy link
Author

Thats just formatting error?

@CAPITAINMARVEL
Copy link
Author

@roman-right i need do the pre commit things ?

@tristandeborde
Copy link

@bedlamzd I'm pretty sure this is a duplicate of #907 for which you already called out the author (#907 (comment))
@CAPITAINMARVEL , this problem is already going to be fixed with #886

@roman-right
Copy link
Member

Hi @CAPITAINMARVEL , could you please check the red tests and there are a few merge conflicts now.
Thank you very much for the PR!

@CAPITAINMARVEL
Create .pre-commit-config.yaml
1c4468e 
Accidentally deleted
@CAPITAINMARVEL
Copy link
Author

Hi @CAPITAINMARVEL , could you please check the red tests and there are a few merge conflicts now. Thank you very much for the PR!

Fixed i accidentally deleted a file

@CAPITAINMARVEL
Copy link
Author

there few problem in it i will remake it ...

@CAPITAINMARVEL CAPITAINMARVEL closed this by deleting the head repository May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@CAPITAINMARVEL @tristandeborde @roman-right