start to use Perflint to improved performance

[07pepa]

added option to ruff to guide developers to use more performant constructs in python

[kewldan]

TL;DR: Partially useful changes

After looking at all your changes, I conclude that they don't affect performance much unless you're chasing nanoseconds. In general, of course, some changes should really be made to the code base. And some that might reduce execution time by n amount of time are not worth it, as they make the code heavier to read. I would consider to commit partial changes.

IMHO

[CAPITAINMARVEL]

TL;DR: Partially useful changes

After looking at all your changes, I conclude that they don't affect performance much unless you're chasing nanoseconds. In general, of course, some changes should really be made to the code base. And some that might reduce execution time by n amount of time are not worth it, as they make the code heavier to read. I would consider to commit partial changes.

IMHO

like if else expression ? making it more difficult to read ?

[kewldan]

TL;DR: Partially useful changes
After looking at all your changes, I conclude that they don't affect performance much unless you're chasing nanoseconds. In general, of course, some changes should really be made to the code base. And some that might reduce execution time by n amount of time are not worth it, as they make the code heavier to read. I would consider to commit partial changes.
IMHO

like if else expression ? making it more difficult to read ?

Not only statements, complicated list/dict comprehension. I didn't say that all changes are useless or over complicated due to reduce execution time, I fully agree with you that some solutions in the current code have some flaws that you want to correct. Don't take it as disrespect 😁

[CAPITAINMARVEL]

TL;DR: Partially useful changes
After looking at all your changes, I conclude that they don't affect performance much unless you're chasing nanoseconds. In general, of course, some changes should really be made to the code base. And some that might reduce execution time by n amount of time are not worth it, as they make the code heavier to read. I would consider to commit partial changes.
IMHO

like if else expression ? making it more difficult to read ?

Not only statements, complicated list/dict comprehension. I didn't say that all changes are useless or over complicated due to reduce execution time, I fully agree with you that some solutions in the current code have some flaws that you want to correct. Don't take it as disrespect 😁

Yeah dont worry, its hard to determine a balance between readability and improving