Fix PydanticObjectId fields being parsed into str when using Pydantic's model_validate_json
#1054
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tic's `model_validate_json` Unsure if this could be fixed in a more stylish fashion, but it was simply incorrectly setup before, at least now it works. **Please make as many changes as needed if this solution could be improved.** I believe this bugfix is quite important. If you parse an ID (let's call the variable `identifier`) from a JSON file in order to look it up on your Mongo database... you won't find it. ```python await cls.find_one(cls.id == identifier) ``` will return `None` even if the object exists, because `identifier` will be of type `str` instead of `ObjectId` when parsing from a JSON file with Pydantic's `model_validate_json`. Fixes BeanieODM#940.
|
No problem! Glad to see it getting fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unsure if this could be fixed in a more stylish fashion, but it was simply incorrectly setup before, at least now it works.
Please make as many changes as needed if this solution could be improved.
I believe this bugfix is quite important. If you parse an ID (let's call the variable
identifier) from a JSON file in order to look it up on your Mongo database... you won't find it.will return
Noneeven if the object exists, becauseidentifierwill be of typestrinstead ofObjectIdwhen parsing from a JSON file with Pydantic'smodel_validate_json.Fixes #940.