Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add python 3.13 and JIT into testing #1051

Merged
merged 2 commits into from
Oct 28, 2024
Merged

add python 3.13 and JIT into testing #1051

merged 2 commits into from
Oct 28, 2024

Conversation

07pepa
Copy link
Member

@07pepa 07pepa commented Oct 11, 2024 •
edited
Loading

  • add python 3.13
  • turn on JIT
  • update code to not raise deprecation warnings

@07pepa 07pepa force-pushed the add-python-3.13-testing branch 2 times, most recently from 6edb435 to c8ed503 Compare October 14, 2024 06:32
@07pepa 07pepa marked this pull request as ready for review October 14, 2024 06:32
@07pepa 07pepa changed the title add python 3.13 into testing add python 3.13 and JIT into testing Oct 14, 2024
@07pepa
add python 3.13 and jit into testing
8becd14 
* add python 3.13
* turn on JIT
* update code to not raise deprecation warnings
Riverfount
Riverfount approved these changes Oct 21, 2024
View reviewed changes
Copy link

@Riverfount Riverfount left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job.

staticxterm
staticxterm reviewed Oct 22, 2024
View reviewed changes
beanie/odm/fields.py Show resolved Hide resolved
pyproject.toml Show resolved Hide resolved
Riverfount
Riverfount previously requested changes Oct 24, 2024
View reviewed changes
Copy link

@Riverfount Riverfount left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two comments need to be answered before this PR can be approved.

staticxterm
staticxterm approved these changes Oct 26, 2024
View reviewed changes
Copy link

@staticxterm staticxterm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for answering the comments. Looks good.

pyproject.toml Show resolved Hide resolved
Riverfount
Riverfount approved these changes Oct 28, 2024
View reviewed changes
Copy link

@Riverfount Riverfount left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@07pepa 07pepa merged commit 22e4acc into BeanieODM:main Oct 28, 2024
61 checks passed
@07pepa 07pepa deleted the add-python-3.13-testing branch October 28, 2024 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@staticxterm staticxterm staticxterm approved these changes

@Riverfount Riverfount Riverfount approved these changes

@CAPITAINMARVEL CAPITAINMARVEL CAPITAINMARVEL approved these changes

@adeelsohailahmed adeelsohailahmed Awaiting requested review from adeelsohailahmed

@LawMixer LawMixer Awaiting requested review from LawMixer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@07pepa @staticxterm @Riverfount @CAPITAINMARVEL