-
Notifications
You must be signed in to change notification settings - Fork 217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix kwargs/args untyped #1049
Fix kwargs/args untyped #1049
Conversation
should be good now only fixed pymongo_kwargs and kwargs and a missing session: Optional[AsyncIOMotorClientSession] = None, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Please remove the stray session typing fix in beanie/odm/interfaces/aggregation_methods.py and leave it for some other commit, let's handle only kwargs/args typings in this PR.
Missed one in beanie/executors/migrate.py:
class MigrationSettings:
def init(self, **kwargs):
But migrate.py in itself is very untyped and should probably be treated/fully typed out in some follow-up task (since we said that this package is fully typed by using the py.typed
).
Other usages are in the __call__
method in beanie/migrations/controllers/free_fall.py and in beanie/migrations/controllers/iterative.py. Then __init__
methods in beanie/odm/documents.py and beanie/odm/operators/find/array.py,
and lastly, in utils: beanie/odm/utils/pydantic.py and beanie/odm/utils/state.py.
This is all that a VSCode search spewed out for me. This should squash them all, then we move to the next ones :)
Should be good now |
c63c4e7
to
96741c2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
ab852d6
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
916e931
to
04916d5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, again! ;-)
No description provided.