Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix kwargs/args untyped #1049

Merged
merged 11 commits into from
Oct 15, 2024

Conversation

CAPITAINMARVEL
Copy link
Contributor

No description provided.

@CAPITAINMARVEL
Copy link
Contributor Author

should be good now only fixed pymongo_kwargs and kwargs and a missing session: Optional[AsyncIOMotorClientSession] = None,

Copy link

@staticxterm staticxterm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Please remove the stray session typing fix in beanie/odm/interfaces/aggregation_methods.py and leave it for some other commit, let's handle only kwargs/args typings in this PR.

Missed one in beanie/executors/migrate.py:
class MigrationSettings:
def init(self, **kwargs):

But migrate.py in itself is very untyped and should probably be treated/fully typed out in some follow-up task (since we said that this package is fully typed by using the py.typed).

Other usages are in the __call__ method in beanie/migrations/controllers/free_fall.py and in beanie/migrations/controllers/iterative.py. Then __init__ methods in beanie/odm/documents.py and beanie/odm/operators/find/array.py,
and lastly, in utils: beanie/odm/utils/pydantic.py and beanie/odm/utils/state.py.

This is all that a VSCode search spewed out for me. This should squash them all, then we move to the next ones :)

@staticxterm staticxterm mentioned this pull request Oct 10, 2024
12 tasks
@CAPITAINMARVEL
Copy link
Contributor Author

Looks good. Please remove the stray session typing fix in beanie/odm/interfaces/aggregation_methods.py and leave it for some other commit, let's handle only kwargs/args typings in this PR.

Missed one in beanie/executors/migrate.py: class MigrationSettings: def init(self, **kwargs):

But migrate.py in itself is very untyped and should probably be treated/fully typed out in some follow-up task (since we said that this package is fully typed by using the py.typed).

Other usages are in the __call__ method in beanie/migrations/controllers/free_fall.py and in beanie/migrations/controllers/iterative.py. Then __init__ methods in beanie/odm/documents.py and beanie/odm/operators/find/array.py, and lastly, in utils: beanie/odm/utils/pydantic.py and beanie/odm/utils/state.py.

This is all that a VSCode search spewed out for me. This should squash them all, then we move to the next ones :)

Should be good now

@CAPITAINMARVEL CAPITAINMARVEL enabled auto-merge (squash) October 10, 2024 21:56
@CAPITAINMARVEL CAPITAINMARVEL changed the title Fix kwargs untyped Fix kwargs/args untyped Oct 10, 2024
Riverfount
Riverfount previously approved these changes Oct 11, 2024
Copy link

@Riverfount Riverfount left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

staticxterm
staticxterm previously approved these changes Oct 12, 2024
beanie/odm/documents.py Outdated Show resolved Hide resolved
LawMixer
LawMixer previously approved these changes Oct 13, 2024
Copy link

@LawMixer LawMixer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link

@Riverfount Riverfount left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, again! ;-)

@CAPITAINMARVEL CAPITAINMARVEL enabled auto-merge (squash) October 14, 2024 14:43
@CAPITAINMARVEL CAPITAINMARVEL merged commit f9d79ff into BeanieODM:main Oct 15, 2024
51 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants