-
Notifications
You must be signed in to change notification settings - Fork 217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set max pymongo version #1027
Set max pymongo version #1027
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch! Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pymongo 4.9.1 seems to work can you try pymongo!=4.9 ?
No, motor 3.5.1 doesnt support 4.9.1. BUT motor has released a 3.6.0 which added a support for pymongo 4.9. So problem is solved. Upgrade your motor library to 3.6.0 |
Should we pin the motor to 3.6.0 then? I'm fine with either/or. |
Good question, it seems to me that yes, you should also specify pymongo~=4.9.1 since such mishaps happen. I would still mark all current used versions as supported, so that a developer who uses beanie can be sure that these dependency versions will work correctly. I'll make the changes now |
Interesting situation, motor latest version supports Python >= 3.8. Although support for Python 3.8 will end in 10 days (full, even security updates), so is it worth the effort and time to support it? This is more of a question for you here, since even the problem with pymongo is related to motor dependencies, not beanie dependencies |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for me i would drop anything that lost support in 3 monts at most but for now we should keep some compatability
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's hold off merging this branch until we deprecate Python 3.7
OK, when you find it necessary to disable support for 3.7 just reopen this PR |
pymongo==4.10.1 was released breaking this once again. |
Motor requires |
Temporary solution:
A new version of pymongo has been released. Beanie doesn't support it yet. When installing motor, the new version 4.9 will be picked up. There will be an ImportError when running the application:
What I did:
Wrote pymongo<4.9 as a library dependency in pyproject.toml