Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix expression type hint not allowing some type https://github.com/BeanieODM/beanie/issues/1020 #1023

Merged
merged 5 commits into from
Sep 24, 2024
Merged

fix expression type hint not allowing some type https://github.com/BeanieODM/beanie/issues/1020 #1023

merged 5 commits into from
Sep 24, 2024

Conversation

CAPITAINMARVEL
Copy link
Contributor

@CAPITAINMARVEL CAPITAINMARVEL commented Sep 6, 2024 •
edited
Loading

fix
#1020

@adeelsohailahmed adeelsohailahmed requested a review from a team September 11, 2024 23:25
07pepa
07pepa previously approved these changes Sep 14, 2024
View reviewed changes
Riverfount
Riverfount approved these changes Sep 18, 2024
View reviewed changes
Copy link

@Riverfount Riverfount left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

adeelsohailahmed
adeelsohailahmed approved these changes Sep 19, 2024
View reviewed changes
Copy link
Contributor

@adeelsohailahmed adeelsohailahmed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes. Looks good to me too.

@07pepa 07pepa merged commit 602e377 into BeanieODM:main Sep 24, 2024
19 checks passed
@CAPITAINMARVEL CAPITAINMARVEL deleted the fix_expression branch October 5, 2024 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@07pepa 07pepa 07pepa approved these changes

@Riverfount Riverfount Riverfount approved these changes

@adeelsohailahmed adeelsohailahmed adeelsohailahmed approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@CAPITAINMARVEL @07pepa @Riverfount @adeelsohailahmed