Add timeout parameter for downloading
#482
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✨ What kind of change does this PR introduce? (Bug fix, feature, docs update...)
This PR is to resolve #141, supporting pass
timeoutfor downloading.There is no way to set
timeout.🆕 What is the new behavior (if this is a feature change)?
A
timeoutduration can be set, and the http request will be timeouted after the duration (aTimeoutExceptionwill be thrown). Iftimeoutis not set, all behaviors are same with the original.💥 Does this PR introduce a breaking change?
N/A
🐛 Recommendations for testing
Check if it will stop and throw a
TimeoutExceptionafter the duration.📝 Links to relevant issues/docs
Issue #141.
🤔 Checklist before submitting