-
-
Notifications
You must be signed in to change notification settings - Fork 261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix linker issue by upgrading Xamarin.AndroidX.AppCompat #399
Fix linker issue by upgrading Xamarin.AndroidX.AppCompat #399
Conversation
Fixes Baseflow#398 Related: Baseflow#397 dotnet/android-libraries#821 After upgrading AndroidX packages in our Xamarin Forms Android project, the linker fails on LottieXamarin using some outdated version of AndroidX types. ``` Error Mono.Linker.MarkException: Error processing method: 'AndroidX.Collection.SparseArrayCompat Com.Airbnb.Lottie.LottieComposition::get_Characters()' in assembly: 'Lottie.Android.dll' ---> Mono.Cecil.ResolutionException: Failed to resolve AndroidX.Collection.SparseArrayCompat ``` ### Changes - Update `Xamarin.AndroidX.AppCompat` from 1.3.1.3 to 1.6.1.6 - Change Android target from monoandroid10.0 to monoandroid12.0 to support newest AndroidX package ### Notes This needs some assistance to fit into the latest changes of `develop` with net6.0 / maui. I'm not sure if this is experimental or not, but I was not able to build it. The PR is currently based on the commit prior to net6.0 / maui update, since our team is currently stuck on standard Xamarin Forms for some time and it solves our need. Maybe we can multi-target both monoandroid12.0 and android-net6.0 to continue support for old Xamarin?
Just a heads up, but I will not be pursuing this PR as we switched to another library instead. https://github.com/mono/SkiaSharp.Extended (must use prerelease nugets as of now) This article was helpful although it explains for MAUI: I'll leave the PR open for anyone stumbling into this later or if you wish to take over the PR. |
@martijn00 , please consider updating using this PR |
Someone merge this and release it - it takes no effort to resolve this |
Pleaase... Someone merge this and release it. @malo-bo can i replicate this PR? |
Please I need this PR too |
@martijn00 whats is the process to release it? there's some CI/CD automation that do i t? |
try this gist instead: https://gist.github.com/softlion/fad8ab6a37809e169d4fcc6b81b0f57b |
Fixes #398
Related:
#397
dotnet/android-libraries#821
After upgrading AndroidX packages in our Xamarin Forms Android project, the linker fails on LottieXamarin using some outdated version of AndroidX types.
Changes
Xamarin.AndroidX.AppCompat
from 1.3.1.3 to 1.6.1.6Notes
This needs some assistance to fit into the latest changes of
develop
with net6.0 / maui. I'm not sure if this is experimental or not, but I was not able to build it.The PR is currently based on the commit prior to net6.0 / maui update, since our team is currently stuck on standard Xamarin Forms for some time and it solves our need. Maybe we can multi-target both monoandroid12.0 and android-net6.0 to continue support for old Xamarin?