Update Check Improvements #1447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@BartoszCichecki Done, ready for review. |
BartoszCichecki
requested changes
Oct 2, 2024
| @@ -47,6 +47,9 @@ public class ApplicationSettingsStore | |||
| public bool SynchronizeBrightnessToAllPowerPlans { get; set; } | |||
| public ModifierKey SmartFnLockFlags { get; set; } | |||
| public bool ResetBatteryOnSinceTimerOnReboot { get; set; } | |||
| public int UpdateCheckMiniumTimeSpanHours { get; set; } | |||
There was a problem hiding this comment.
I think this is a bit much. I guess a drop down with some values like hourly, daily, weekly, monthly etc.
It would be also nice to store this as an actual TimeSpan instead of ints.
BartoszCichecki
approved these changes
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #1410.
This PR contains a group of improvements on LLT update check function.
TODO:
Display last update check time on settings pagecanceledThe
Check Updatebutton do the same thing as auto update check is triggered on startup / window load. It calls theCheckForUpdatefunction provided byMainWindowclass, which is the easiest way.I also add an error-handling function for checking updates manually. Since this
Check Updatebutton would force check updates from remote, it is more likely to reach the API rate limit. I also thought about removing the force check arg, but it doesn't make sense for a manual check trigger. Therefore results will be shown after the manual check, like "no new updates", "reached API rate limit", or `sth was wrong". But these are only for this manual check, normal auto-check won't show these msgs, since it would be a bit annoying.Regarding to displaying last update check time on settings page, there's sth I cannot handle with when updating the time dynamically. It's also not so important (I think), so I cancaled this feature plan.