Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Troop recruitment #1081

Merged
merged 13 commits into from
Feb 9, 2025
Merged

Troop recruitment #1081

merged 13 commits into from
Feb 9, 2025

Conversation

EgardA
Copy link
Contributor

@EgardA EgardA commented Feb 9, 2025

PR Checklist

Please check if your PR fulfills the following requirements:

  • All new classes have class-level documentation comments, if there are any at all
  • Tests for the changes have been added (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation update
  • Other... Please describe:

What is the current behavior?

No recruitment sync

What is the new behavior?

Resolves #652

Syncs troop recruitment, TroopRoster still has a collection with TroopRosterElements that needs to be synced for full functionality. This will be done in a seperate PR as the issues it creates has not been enabled in this PR.

Other information

@garrettluskey garrettluskey merged commit e54847b into development Feb 9, 2025
2 checks passed
@garrettluskey garrettluskey deleted the troop-recruitment branch February 9, 2025 00:40
@garrettluskey garrettluskey restored the troop-recruitment branch February 9, 2025 00:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Sync Troop Recruitment
3 participants