Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync: Kingdom Fields #1077

Merged
merged 3 commits into from
Jan 26, 2025
Merged

Sync: Kingdom Fields #1077

merged 3 commits into from
Jan 26, 2025

Conversation

brodrigz
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

  • All new classes have class-level documentation comments, if there are any at all
  • Tests for the changes have been added (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation update
  • Other... Please describe:

What is the current behavior?

Kingdom fields not synced

What is the new behavior?

Resolves #881

Field Name Sync Type Additional Information
PoliticalStagnation Server side
_aggressiveness Server side
_isEliminated Server side
_kingdomBudgetWallet Server side
_kingdomMidSettlement Server side
_rulingClan Server side
_tributeWallet Server side
_distanceToClosestNonAllyFortificationCacheDirty Server side

Other information

The first commit was made entirely by running coop-create all "TaleWorlds.CampaignSystem.Kingdom, TaleWorlds.CampaignSystem" --members PoliticalStagnation _aggressiveness _isEliminated _kingdomBudgetWallet _kingdomMidSettlement _rulingClan _tributeWallet _distanceToClosestNonAllyFortificationCacheDirty

This PR is also a proof of concept for the new scaffolding CLI, by reviewing it you are also reviewing the CLI's template files.

@brodrigz brodrigz marked this pull request as ready for review January 25, 2025 18:25
@garrettluskey garrettluskey merged commit e8a7741 into development Jan 26, 2025
2 checks passed
@garrettluskey garrettluskey deleted the 881-kingdom-fields branch January 26, 2025 02:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Sync: Kingdom Fields
2 participants