-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Item object sync #1076
Open
ShackMcBlack
wants to merge
7
commits into
development
Choose a base branch
from
ItemObjectSync
base: development
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Item object sync #1076
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Synced ItemObject Properties Listed in #994. Vec3 will need to be Serialized
Synced ItemObject Collections
Added Vec3 Surrogate
Readded HolsterPositionShift to Sync and Tests
Need to add remainder of properties |
Also added surrogates for all the object needed for serialization.
Changed ItemComponentSurrogate.Item to ItemObject
EgardA
reviewed
Feb 8, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are some problems with the items being classes, as they need to have their lifetime handled. I made some changes to the test so that it now correctly shows if it is working as intended 😄 Reach out if you need some help! 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
What is the new behavior?
Resolves #994
Resolves #997
Other information
Some ProtoMembers are ignored to prevent circular recursion, I tried to pick the ones that would be least impactful. See ItemCategorySurrogate.CanSubstitute and ItemObjectSurrogate.ItemComponent (ItemComponent.Item is of type ItemObject). Let me know if there is a better way around this.
Also one MapEvent test seems to fail but I could not immediately figure out why. I can look into it and see if there's something I did stupid.