Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Item object sync #1076

Open
wants to merge 7 commits into
base: development
Choose a base branch
from
Open

Item object sync #1076

wants to merge 7 commits into from

Conversation

ShackMcBlack
Copy link
Contributor

@ShackMcBlack ShackMcBlack commented Jan 24, 2025

PR Checklist

Please check if your PR fulfills the following requirements:

  • All new classes have class-level documentation comments, if there are any at all
  • Tests for the changes have been added (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation update
  • Other... Please describe:

What is the current behavior?

What is the new behavior?

Resolves #994
Resolves #997

Other information

Some ProtoMembers are ignored to prevent circular recursion, I tried to pick the ones that would be least impactful. See ItemCategorySurrogate.CanSubstitute and ItemObjectSurrogate.ItemComponent (ItemComponent.Item is of type ItemObject). Let me know if there is a better way around this.

Also one MapEvent test seems to fail but I could not immediately figure out why. I can look into it and see if there's something I did stupid.

Synced ItemObject Properties Listed in #994. Vec3 will need to be Serialized
Synced ItemObject Collections
Added Vec3 Surrogate
Readded HolsterPositionShift to Sync and Tests
@ShackMcBlack ShackMcBlack marked this pull request as draft January 24, 2025 14:41
@ShackMcBlack
Copy link
Contributor Author

Need to add remainder of properties

Also added surrogates for all the object needed for serialization.
Changed ItemComponentSurrogate.Item to ItemObject
@ShackMcBlack ShackMcBlack requested review from garrettluskey and EgardA and removed request for garrettluskey January 31, 2025 23:10
@ShackMcBlack ShackMcBlack self-assigned this Jan 31, 2025
@ShackMcBlack ShackMcBlack marked this pull request as ready for review January 31, 2025 23:20
Copy link
Contributor

@EgardA EgardA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some problems with the items being classes, as they need to have their lifetime handled. I made some changes to the test so that it now correctly shows if it is working as intended 😄 Reach out if you need some help! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Todo
Development

Successfully merging this pull request may close these issues.

ItemObject Collections Sync ItemObject Property Sync
2 participants