Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ItemObject Sync #1075

Merged
merged 3 commits into from
Jan 22, 2025
Merged

ItemObject Sync #1075

merged 3 commits into from
Jan 22, 2025

Conversation

ShackMcBlack
Copy link
Contributor

@ShackMcBlack ShackMcBlack commented Jan 22, 2025 •
edited
Loading

PR Checklist

Please check if your PR fulfills the following requirements:

  • All new classes have class-level documentation comments, if there are any at all
  • Tests for the changes have been added (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation update
  • Other... Please describe:

What is the current behavior?

What is the new behavior?

Resolves #995

Other information

This is my first issue, please berate and belittle as you see fit. It does not seem to crash.

@ShackMcBlack
ItemObject Field Sync
a05ce9a 
ItemObject Field Sync, Resolves #995
@ShackMcBlack
Removed Comments
b10defd 
Removed Comments for Myself
@ShackMcBlack ShackMcBlack self-assigned this Jan 22, 2025
@ShackMcBlack ShackMcBlack reopened this Jan 22, 2025
@ShackMcBlack ShackMcBlack changed the title 995 ItemObject Field Sync ItemObject Sync Jan 22, 2025
@ShackMcBlack ShackMcBlack marked this pull request as draft January 22, 2025 20:45
@ShackMcBlack
Namespace Rename and Test Fix
5755f54 
Renamed Namespace and Fixed Test
@EgardA EgardA marked this pull request as ready for review January 22, 2025 23:51
@EgardA
Copy link
Contributor

EgardA commented Jan 22, 2025

LGTM

@EgardA EgardA merged commit 7bc549c into development Jan 22, 2025
2 checks passed
@EgardA EgardA deleted the 995-ItemObject-Field-Sync branch January 22, 2025 23:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EgardA EgardA EgardA approved these changes

Assignees

@ShackMcBlack ShackMcBlack

Labels
None yet
Projects
Coop Mod Backlog
Status: Done
Sync Backlog
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ItemObject Field Sync
2 participants
@ShackMcBlack @EgardA