Fix bugs in undocumented sparse matrix conversion functions #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'll add tests before merging this PR. But I want to note these necessary changes now as I'm discovering them.
Changes since 1.0.0: * Resolved #118. * Resolved minor bugs in values of RNGState objects returned from sample_indices_iid and sample_indices_iid_uniform. * Changed certain template defaults from ``r123::Philox4x32`` to ``DefaultRNG``. * Replaced the RNGState constructor which previously accepted ``RNG::key_type::value_type`` to now accept``std::uint64_t``. This has the benefit of allowing any initial key for RandBLAS' default RNG, as opposed to only allowing keys of the form ``{k, 0}`` for some uint32 ``k``. * Added ``sqrt_epsilon<T>()`` to the web documentation. * Clarify that any functions which appear in the web documentation are part of our public API, for purposes of semantic versioning.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'll add tests before merging this PR. But I want to note these necessary changes now as I'm discovering them.
A note: these functions were for converting from CSC or CSR format to COO format. Our examples which read sparse matrices from disk and run low-rank approximation algorithms were never unaffected. Those files only use conversions from COO to CSC or CSR.