Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add no_std support #32

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add no_std support #32

wants to merge 1 commit into from

Conversation

TTWNO
Copy link

@TTWNO TTWNO commented May 17, 2024

Hi there,

I'm working on a project to get an extremely minimal TTS working in Rust.
As part of the requirements, my library needs to be #![no_std].
It'd be nice to take advantage of existing libraries; and yours is very easily adapted to no_std.
This makes that simple change.

The only two future consideration are:

  • anything that does depend on std will need to be behind a feature flag, and
  • you may want to enable std_instead_of_alloc; this will suggest that any imports from std:: be changed to alloc:: where possible.

Thanks for putting in the hard work for this!

@TTWNO TTWNO marked this pull request as ready for review May 17, 2024 19:24
@Ballasi
Copy link
Owner

Ballasi commented May 20, 2024

Hey, thanks for opening that PR!

I am relatively busy lately so I might take a bit of time to take a look and answer your PR (the other PR dates back from 1+ month which is completely horrendous...), even though it doesn't look that complicated.

Thanks for taking the time to participate in this project. I'll answer ASAP.

@Laifsyn
Copy link

Laifsyn commented May 23, 2024

I'm not in particular hurry since I was planning to see if I could change from a loop into an iterator
Update: I couldn't make it work with an Iterator. (I wanted to reduce allocations mainly)

@TTWNO
Copy link
Author

TTWNO commented Sep 13, 2024

@Ballasi just checking in. No rush, I just had to use my git version of the project again for a no_std target and wanted to see if progress could be made regarding a review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants