Reduce promises version to 1.1.0 and safeguard visibility test (rstud…

…io#3252)
BahgatN · Jan 12, 2021 · 213f0d3 · 213f0d3
1 parent 5b27d92
commit 213f0d3
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 2 deletions.
diff --git a/DESCRIPTION b/DESCRIPTION
@@ -85,7 +85,7 @@ Imports:
     R6 (>= 2.0),
     sourcetools,
     later (>= 1.0.0),
-    promises (>= 1.1.1.9001),
+    promises (>= 1.1.0),
     tools,
     crayon,
     rlang (>= 0.4.9),
@@ -116,7 +116,6 @@ Suggests:
     sass
 Remotes:
     rstudio/htmltools,
-    rstudio/promises,
     rstudio/sass,
     rstudio/bslib,
     rstudio/shinytest,

diff --git a/tests/testthat/test-bind-cache.R b/tests/testthat/test-bind-cache.R
@@ -923,6 +923,9 @@ test_that("bindCache visibility", {
 
 
 test_that("bindCache reactive visibility - async", {
+  # only test if promises handles visibility
+  skip_if_not_installed("promises", "1.1.1.9001")
+
   cache <- cachem::cache_mem()
   k <- reactiveVal(0)
   res <- NULL

diff --git a/tests/testthat/test-hybrid-chain.R b/tests/testthat/test-hybrid-chain.R
@@ -27,6 +27,9 @@ test_that("hybrid_chain preserves visibility", {
 
 
 test_that("hybrid_chain preserves visibility - async", {
+  # only test if promises handles visibility
+  skip_if_not_installed("promises", "1.1.1.9001")
+
   res <- NULL
   hybrid_chain(
     promise_resolve(1),