Test BN Compatibility tool and github action #569
Conversation
CedricGuillemet
requested review from
bghgary,
docEdub,
ryantrem and
SergioRZMasson
Apps/TestProtocol/testBNProtocol.js
Outdated
| compatibility.push({tag:tag, hash:hash, npms:compatiblePackageVersions}); | ||
| } | ||
|
|
||
| BRNVersions.forEach((versionToTest) =>{ |
There was a problem hiding this comment.
Is it a goal to be able to run this for every version locally? Would it make more sense for the version to be an input to the script, and then use a GitHub actions matrix thing to be able to run them all in parallel across multiple machines?
There was a problem hiding this comment.
Yes, it would be faster to run. And it should also use the result from last run to not re-test everything.
Documentation/TestingProtocol.md
Outdated
| @@ -0,0 +1,35 @@ | |||
| # Testing BabylonNative Protocol | |||
There was a problem hiding this comment.
When should we use this new tool? Any time a new BJS version is released? Maybe add some comments about that in this doc?
There was a problem hiding this comment.
It should run :
- once a week to test new bjs package(s)
- after each BRN NPM package release
Apps/TestProtocol/testBNProtocol.js
Outdated
|
|
||
| function checkoutAndBuildBN(tag, hash, callback) { | ||
| console.log("Git clone."); | ||
| execute('git clone https://github.com/BabylonJS/BabylonNative.git', './', (error, stdout, stderr) => { |
There was a problem hiding this comment.
Oy. Can we use Promises and async/await in this code? It's just a node.js script, right?
There was a problem hiding this comment.
Yes, it's a Node.js script.
.github/workflows/test_protocol.yml
Outdated
| @@ -0,0 +1,29 @@ | |||
| name: Test BabylonNative Protocol compatibility | |||
There was a problem hiding this comment.
Like we discussed offline, this isn't just testing the protocol version. Rename folder to TestCompatibility, etc.?
CedricGuillemet
changed the title
CedricGuillemet
changed the title
Co-authored-by: Andy Fillebrown <[email protected]>
Co-authored-by: Andy Fillebrown <[email protected]>
|
|
||
| function checkoutAndBuildBN(tag, hash, callback) { | ||
| console.log("Git clone."); | ||
| execute('git clone https://github.com/BabylonJS/BabylonNative.git', './', (error, stdout, stderr) => { |
There was a problem hiding this comment.
Can we use async/await here to make this more readable?
…ylonJS#580) * Agnostic toolset for VS project * platform tool version * pragma for std * Update Modules/@babylonjs/react-native-windows/windows/BabylonReactNative/BabylonReactNative.vcxproj Co-authored-by: Gary Hsu <[email protected]> * update windows readme --------- Co-authored-by: Gary Hsu <[email protected]>
* 1.6.1 SLA update * removed empty space
* Update BN submodule * BN #883ba13 * a676d6df117cb6cdebc5c347b8aa37f2fed852fb * cmake + brn up * cmake update * removed comment * comment * GraphicsDevice * graphics init * android rn 0.71 * back to 0.64
Runs a list of BabylonNative commit against a range of Babylon.js NPM version to list compatible versions.
The list is then uploaded as an artifact.