Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Babylon.js 7.6.2 #1373

Merged
merged 26 commits into from
May 17, 2024
Merged

Update to Babylon.js 7.6.2 #1373

merged 26 commits into from
May 17, 2024

Conversation

bghgary
Copy link
Contributor

@bghgary bghgary commented Mar 28, 2024

Updating to Babylon.js version 7.0.0 reveals a whole slew of issues when running the validation tests because #14868 broke the render loop stopping behavior when running in native. Native does not implement a way to cancel a requested animation frame. This missing canceling functionality should be added to native someday, but, in the meantime, #15086 will make it behave like it did before.

These changes fix potential issues in the code regardless of what happened on the JS side.

  • Update to latest JsRuntimeHost with lots of fixes.
  • Call SetRenderResetCallback with null to clear the callback that can cause a crash on shutdown.
  • Update a few validation tests to not use render count.
  • Update scripts to use const/let instead of var.
  • Update validation script to handle some errors better and clean up dead code.
  • Add unhandled exception handler to Playground app so that validation test will report correct errors and exit correctly.
  • Change core graphics device implemenation to update bgfx state right before requesting screenshots. This will ensure the screenshot is the right size if the resolution has changed.
  • Fix TestUtils:WritePNG to return an error when the byte length is an unexpected size instead of silently failing.
  • Change TestUtils::SetTitle to update the HWND title on a background thread to avoid dead lock with the main thread.
  • Update dynamic texture clip test to newest version that will fail if the feature is not working.

- Update a few validation tests to not use render count.
- Update scripts to use `const`/`let` instead of `var`.
- Update validation script to handle some errors better and clean up dead code.
- Add unhandled exception handler to Playground app so that validation test will report correct errors and exit correctly.
- Change core graphics device implemenation to update bgfx state right before requesting screenshots. This will ensure the screenshot is the right size if the resolution has changed.
- Fix TestUtils:WritePNG to return an error when the byte length is an unexpected size instead of silently failing.
- Change TestUtils::SetTtitle to update the HWND title on a background thread to avoid dead lock with the main thread.
@bghgary bghgary requested a review from ryantrem April 6, 2024 00:24
@bghgary bghgary marked this pull request as draft April 6, 2024 00:24
@bghgary bghgary changed the title Update to Babylon.js 7.0.0 Update to Babylon.js 7.6.1 May 14, 2024
@bghgary bghgary removed the request for review from CedricGuillemet May 14, 2024 00:36
@bghgary bghgary changed the title Update to Babylon.js 7.6.1 Update to Babylon.js 7.6.2 May 16, 2024
@bghgary bghgary marked this pull request as ready for review May 16, 2024 19:22
@bghgary bghgary merged commit 4cf5677 into BabylonJS:master May 17, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants