-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to Babylon.js 7.6.2 #1373
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryantrem
approved these changes
Mar 28, 2024
- Update a few validation tests to not use render count. - Update scripts to use `const`/`let` instead of `var`. - Update validation script to handle some errors better and clean up dead code. - Add unhandled exception handler to Playground app so that validation test will report correct errors and exit correctly. - Change core graphics device implemenation to update bgfx state right before requesting screenshots. This will ensure the screenshot is the right size if the resolution has changed. - Fix TestUtils:WritePNG to return an error when the byte length is an unexpected size instead of silently failing. - Change TestUtils::SetTtitle to update the HWND title on a background thread to avoid dead lock with the main thread.
bghgary
commented
Apr 19, 2024
ryantrem
approved these changes
Apr 19, 2024
bghgary
commented
Apr 19, 2024
…into update-bjs
ryantrem
approved these changes
May 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating to Babylon.js version 7.0.0 reveals a whole slew of issues when running the validation tests because #14868 broke the render loop stopping behavior when running in native. Native does not implement a way to cancel a requested animation frame. This missing canceling functionality should be added to native someday, but, in the meantime, #15086 will make it behave like it did before.
These changes fix potential issues in the code regardless of what happened on the JS side.
const
/let
instead ofvar
.