Add official Dockerfile to the project #339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Dockerfile now uses a multi-stage build which compiles the source in one image and then copies binaries into a second clean image. This reduces the final image size from 758MB to 67.5MB, and is further reduced to 19.2MB by striping the compiled binaries. The branch/tag of the Git checkout was required to be specified previously, but now has a default of 2.4 if not provided. Custom plugins are automatically copied into the build image and compiled by including them in a custom_plugins directory. A directory/volume is created at /data in the final image which can be mapped to a directory on the host system for configuration, world, groups, and other files.
Instead of using git inside the build container, just copy the source directory from the host system. This makes it much easier to test local changes since it does not need to be committed and pushed first. It also makes the build process more familiar since custom plugins can just be added to the plugins/ directory like normal, and configure flags can be passed to the 'configure' build argument.
* Use alpine:3 instead of alpine:3.18 so we track the latest 3.x version * Add --no-cache to apk add to keep the image size down * Remove the unnecessary VOLUME * Add a plugins build argument as a shortcut for the configure script --enable-custom-plugins option
|
Is there anything else to add to this before it would get merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creating this PR so that if any discussions need to happen, they can happen here. Right now, I'm just documenting how to use the Dockerfile
Building the container
Running the container