Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/36 improve response types for grpc support #37

Merged
merged 4 commits into from
Jun 8, 2023
Merged

Feature/36 improve response types for grpc support #37

merged 4 commits into from
Jun 8, 2023

Conversation

Reza-Noei
Copy link
Contributor

@Reza-Noei Reza-Noei commented Jun 8, 2023 •
edited by soroshsabz
Loading

ITNOA

Please review this PR 馃尮

fixes #36

soroshsabz
soroshsabz requested changes Jun 8, 2023
View reviewed changes
Copy link
Member

@soroshsabz soroshsabz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Reza-Noei Please consider the notes

thanks

Source/BSN.Commons.Orm.EntityFramework/BSN.Commons.Orm.EntityFramework.csproj Show resolved Hide resolved
Source/BSN.Commons.Orm.EntityFrameworkCore/Extensions/IQueryableExtensions.cs Show resolved Hide resolved
Source/BSN.Commons.PresentationInfrastructure/Responses/GenericResponseBase.cs Show resolved Hide resolved
Source/BSN.Commons.PresentationInfrastructure/Responses/GenericResponseBaseWithPagination.cs Show resolved Hide resolved
@soroshsabz soroshsabz merged commit e3235e4 into master Jun 8, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soroshsabz soroshsabz soroshsabz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve response types for grpc support
2 participants
@Reza-Noei @soroshsabz