Feature/improvement-on-repositories (#31)

* Add extra overload for GetById. * Make GetById method generic.
BSVN · Dec 8, 2022 · 4e34b04 · 4e34b04
1 parent 1108b26
commit 4e34b04
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 20 deletions.
diff --git a/Source/BSN.Commons.Orm.EntityFramework/RepositoryBase.cs b/Source/BSN.Commons.Orm.EntityFramework/RepositoryBase.cs
@@ -129,12 +129,7 @@ public virtual void DeleteRange(IEnumerable<T> entities)
  dbSet.RemoveRange(entities);
  }
 
- public virtual T GetById(long id)
- {
- return dbSet.Find(id);
- }
-
- public virtual T GetById(string id)
+ public virtual T GetById<KeyType>(KeyType id)
  {
  return dbSet.Find(id);
  }

diff --git a/Source/BSN.Commons.Orm.EntityFrameworkCore/RepositoryBase.cs b/Source/BSN.Commons.Orm.EntityFrameworkCore/RepositoryBase.cs
@@ -40,12 +40,7 @@ public void DeleteRange(IEnumerable<T> entities)
  dbSet.RemoveRange(entities);
  }
 
- public virtual T GetById(long id)
- {
- return dbSet.Find(id);
- }
-
- public virtual T GetById(string id)
+ public virtual T GetById<KeyType>(KeyType id) 
  {
  return dbSet.Find(id);
  }

diff --git a/Source/BSN.Commons/Infrastructure/IRepository.cs b/Source/BSN.Commons/Infrastructure/IRepository.cs
@@ -66,14 +66,7 @@ public interface IRepository<T> where T : class
  /// </summary>
  /// <param name="id">Object Id</param>
  /// <returns>Retrived Object or null</returns>
- T GetById(long id);
-
- /// <summary>
- /// Get Object by id.
- /// </summary>
- /// <param name="id">Object Id</param>
- /// <returns>Retrived Object or null</returns>
- T GetById(string id);
+ T GetById<KeyType>(KeyType id);
 
  /// <summary>
  /// Get Object by Expression.