Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix /etc/init/docker.conf patch for Docker 1.10 #98

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

adderan
Copy link
Contributor

@adderan adderan commented Feb 8, 2016

In docker 1.10, the Upstart docker.conf script has been changed slightly, making the patch fail in toil box.

Docker 1.10: https://github.com/docker/docker/blob/master/contrib/init/upstart/docker.conf

Docker 1.9.1: https://github.com/docker/docker/blob/v1.9.1/contrib/init/upstart/docker.conf

I don't know whether you should actually merge this or not, since you're considering pinning Docker at 1.9.1.

@hannes-ucsc
Copy link
Contributor

I'll definitely want to merge this (in conjunction with pinning Toil to 1.10). Can you say a little more about the symptoms you ran into that triggered you make these changes? Is this a fix for #97 and if not, I wonder why you aren't running into #97.

@adderan
Copy link
Contributor Author

adderan commented Feb 8, 2016

I did run in to #97, but waited about 5 minutes for the tar to complete, at which point the patch immediately failed. I don't have the exact log output anymore, but it was clear that the patch didn't apply to that version of docker.conf. It works after making this change. But in adaba9a John pins docker-engine to 1.9.1, which will make it necessary to undo this PR.

@hannes-ucsc
Copy link
Contributor

John's commit was cherry-picked into the stable branch as well, so I think the way forward for the master branch is to move the pin to 1.10, merge this PR and fix #97.

John waited in excess of 10 minutes and nothing had happened.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants