Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Created React App #65

Closed
wants to merge 3 commits into from
Closed

Created React App #65

wants to merge 3 commits into from

Conversation

Ashuto7h
Copy link

@Ashuto7h Ashuto7h commented Feb 12, 2021

Description of the change

Implemented React app and backend in python.

Related Issues & Documents

Issue #31
Issue #57

What type of PR is this?

  • New Feature

QA Instructions(if necessary), Screenshots of Output or Recordings

image

web app structure -

__ react_app
    |__client (contains react app)
    |__server (contains flask backend)

To run the react app

  • open cmd in the client folder
  • run command npm install
  • run command npm start

To run the flask backend

  • move to server folder
  • install requirements.
  • run the command flask run

This PR contains the react app as described in issue #31, along with some nice animation effects.

Everything is working fine except the file upload button. I will try to fix it in the next PR.

Added tests?

  • No, because they aren't needed

Added to documentation / readme or updated requirements.txt(if needed)?

  • Changed documentation in readme
  • Updated requirements.txt

@Ashuto7h Ashuto7h changed the title initialized react app Created React App Feb 12, 2021
@Ashuto7h Ashuto7h marked this pull request as ready for review February 16, 2021 17:36
@BALaka-18
Copy link
Owner

BALaka-18 commented Feb 18, 2021

@Ashuto7h looks good, will review soon.
However, your logo and color scheme don't go hand in hand with what others working on this issue had submitted earlier. Did you collaborate with them ?

@Ashuto7h
Copy link
Author

Ashuto7h commented Feb 19, 2021

No I didn't collaborated with them.
I just followed the conversation on issues and created this.

The issue was not active for a long time and @kenkirito just allowed me to work on it.

I will later change the color scheme and logo according to what you want.

@Ashuto7h Ashuto7h closed this Jan 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants